refactor: SessionStateExt and SessionConfigExt #1130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moving them out from util to their own module as util is too busy, also it will align with naming in used in client. also, split `SessionConfigExt` to `SessionConfigExt` and `SessionConfigHelperExt`. `SessionConfigExt` will stay user facing, `SessionConfigHelperExt` will be used internally. This reduces ballista client public api
andygrove
approved these changes
Nov 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes none.
Rationale for this change
separation of concerns of internal modules and reducing public api removing methods not commonly ysed
What changes are included in this PR?
refactor
SessionStateExtandSessionConfigExtmoving them out from util to their own module asutil is too busy, also it will align with naming in used in client.
also, split
SessionConfigExttoSessionConfigExtandSessionConfigHelperExt.SessionConfigExtwill stay user facing,
SessionConfigHelperExtwill be used internally. This reduces ballistaclient public API
Are there any user-facing changes?
No