Skip to content

fix: workaround to get benchmarks working again #1184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andygrove wants to merge 2 commits into from
Closed

fix: workaround to get benchmarks working again #1184

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2352840
it works
andygrove Feb 16, 2025
b48444a
prep for review
andygrove Feb 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ballista/executor/src/flight_service.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,9 +234,9 @@ where
if let SendError(Err(err)) = err {
err
} else {
FlightError::Tonic(Status::internal(
"Can't send a batch, something went wrong",
))
FlightError::Tonic(Status::internal(format!(
"Can't send a batch, something went wrong: {err:?}"
)))
}
})?
}
Expand Down
9 changes: 8 additions & 1 deletion benchmarks/src/bin/tpch.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -352,12 +352,19 @@ async fn benchmark_ballista(opt: BallistaBenchmarkOpt) -> Result<()> {
println!("Running benchmarks with the following options: {opt:?}");
let mut benchmark_run = BenchmarkRun::new(opt.query);

let config = SessionConfig::new_with_ballista()
let mut config = SessionConfig::new_with_ballista()
.with_target_partitions(opt.partitions)
.with_ballista_job_name(&format!("Query derived from TPC-H q{}", opt.query))
.with_batch_size(opt.batch_size)
.with_collect_statistics(true);

// workaround for https://github.com/apache/datafusion-ballista/issues/1182
config
.options_mut()
.execution
.parquet
.schema_force_view_types = false;

let state = SessionStateBuilder::new()
.with_default_features()
.with_config(config)
Expand Down
Loading