Skip to content

chore: minor release script fix #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Mar 5, 2025
Merged

chore: minor release script fix #1192

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions dev/release/create-tarball.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,11 +53,6 @@ if [ "$#" -ne 2 ]; then
exit
fi

if [[ -z "${GH_TOKEN}" ]]; then
echo "Please set personal github token through GH_TOKEN environment variable"
exit
fi
Comment on lines -56 to -59
Copy link
Member Author

@andygrove andygrove Mar 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script does not use git


version=$1
rc=$2
tag="${version}-rc${rc}"
Expand Down Expand Up @@ -101,6 +96,8 @@ The standard verification procedure is documented at https://github.com/apache/d
[ ] +0
[ ] -1 Do not release this as Apache DataFusion Ballista ${version} because...

Here is my vote: +1

[1]: https://github.com/apache/datafusion-ballista/tree/${release_hash}
[2]: ${url}
[3]: https://github.com/apache/datafusion-ballista/blob/${release_hash}/CHANGELOG.md
Expand Down
Loading