minor: executor_shutdown_while_running test has race condition
#1248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leading for barrier never to get triggered
milenkovicm
changed the title
executor_shutdown_while_running test has race condition
andygrove
approved these changes
Apr 21, 2025
milenkovicm
changed the title
executor_shutdown_while_running test has race conditionexecutor_shutdown_while_running test has race condition
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #235
Rationale for this change
What changes are included in this PR?
executor_shutdown_while_running test has race between spawning task and shutdown, leading to barrier not getting triggered
Are there any user-facing changes?