document private items and update docs CI #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killzoner
force-pushed
the
main
branch
2 times, most recently
from
8d7c467 to
ec167e3
Compare
milenkovicm
approved these changes
Oct 14, 2025
Contributor
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
looks good @killzoner , thanks!
one minor comment
Merged
milenkovicm
approved these changes
Oct 14, 2025
Contributor
|
thanks @killzoner |
Contributor
Author
Thank you for the reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes partially https://github.com/apache/datafusion-ballista/issues/1258 #.
Rationale for this change
#1258 would need
#![warn(missing_docs)], but there is currently a lot of missing documentation.This is a first step towards avoid functions not appearing in documentation.
What changes are included in this PR?
Updating the CI to have (partially) same checks around docs as
datafusion.Are there any user-facing changes?
Will document private items, so they will now appear in docs.