Skip to content

fix: Executor does not panic if using unwritable work dir #1332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milenkovicm merged 1 commit into from
Oct 24, 2025
Merged

fix: Executor does not panic if using unwritable work dir #1332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions ballista/executor/src/executor_process.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,10 +163,16 @@ pub async fn start_executor_process(
let scheduler_port = opt.scheduler_port;
let scheduler_url = format!("http://{scheduler_host}:{scheduler_port}");

let work_dir = opt
.work_dir
.clone()
.unwrap_or(TempDir::new()?.path().to_str().unwrap().to_string());
let work_dir = if let Some(work_dir) = opt.work_dir.clone() {
work_dir
} else if let Some(temp_dir) = TempDir::new()?.path().to_str().map(ToOwned::to_owned)
{
temp_dir
} else {
return Err(BallistaError::Configuration(
"Unable to bind work dir".to_string(),
));
};

let concurrent_tasks = if opt.concurrent_tasks == 0 {
// use all available cores if no concurrency level is specified
Expand Down