-
Notifications
You must be signed in to change notification settings - Fork 260
chore(doc): Clean up deployment docs. #1354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milenkovicm
reviewed
Dec 31, 2025
Contributor
milenkovicm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @LouisBurke changes look ok, but docker action is failing
|
|
||
| # create build user with same UID as | ||
| RUN adduser -q -u $EXT_UID builder --home /home/builder && \ | ||
| RUN adduser -q builder --home /home/builder && \ |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this is failing github action
milenkovicm
approved these changes
Jan 2, 2026
Contributor
|
Thanks @LouisBurke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This PR adds changes the Deployment section of the docs after they've been reviewed.
Closes #.
Rationale for this change
This change:
What changes are included in this PR?
Markdown document changes.
Are there any user-facing changes?
The reader of the docs should have an easier time setting up ballista components.
There shouldn't be any breaking changes.