-
Notifications
You must be signed in to change notification settings - Fork 260
feat: update rust edition to 2024 #1355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eafadf0 to
96c9253
Compare
|
I noticed that Fixed msrv check which was actually wrong - my bad ! - ( |
|
what if we do not change anything in python directory and leave it as it was? keep msrv and dependencies as they were? |
|
Fine by me |
milenkovicm
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think other changes are ok, just revert changes to python please
This should be good now. Added the cargo resolver upgrade since the previous push |
|
Thanks @killzoner |
|
Thank you for the quick feedbacks! |
|
there are two fresh new issues if you're interested @killzoner |
Sure, happy to take on these |
Which issue does this PR close?
Closes #1271
Revival of #1290
I added pyballista migration too compared to the previous PRRationale for this change
Update Rust edition. Now possible since upstream datafusion 51 is targeting a recent enough rust MSRV
What changes are included in this PR?
Are there any user-facing changes?
No