fix: prost build keda and TLS RPC example #1429
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
killzoner
force-pushed
the
fix-prost-build-keda
branch
from
cc864db to
cc3a3d8
Compare
killzoner
force-pushed
the
fix-prost-build-keda
branch
from
e88b5fe to
b5a2782
Compare
killzoner
changed the title
killzoner
changed the title
killzoner
changed the title
killzoner
force-pushed
the
fix-prost-build-keda
branch
2 times, most recently
from
ebd2994 to
c10fbbe
Compare
killzoner
force-pushed
the
fix-prost-build-keda
branch
from
c10fbbe to
572d7d5
Compare
milenkovicm
reviewed
Jan 30, 2026
| description: 'Prepare Rust Build Environment' | ||
| inputs: | ||
| cmake: | ||
| description: 'install cmake' |
Contributor
Author
There was a problem hiding this comment.
snmalloc-rs does, and since we run lint with --all-features, it's needed
We might just remove snmalloc since it's not really maintained for now, donated to microsoft root project but no active publication to crates.io since then
Contributor
There was a problem hiding this comment.
i dont think anybody is using it, please remove it if you can @killzoner
Contributor
Author
There was a problem hiding this comment.
All right i'll remove it and put back the default CI without cmake
Contributor
Author
There was a problem hiding this comment.
It's removed (both cmake and snmalloc)
milenkovicm
approved these changes
Jan 31, 2026
Contributor
milenkovicm
left a comment
milenkovicm
left a comment
There was a problem hiding this comment.
it looks ok, thanks @killzoner
martin-g
pushed a commit
to martin-g/datafusion-ballista
that referenced
this pull request
Feb 1, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No issue opened. Noticed this working on #1395 and running
cargo clippy --workspace --all-targets --all-features -- -D warnings ;Rationale for this change
The build with
keda-scalerfeature is broken (along with few other things)What changes are included in this PR?
keda-scalerproto build--all-featuresI can split the commits in separate PRs if desirable
Are there any user-facing changes?
No