Skip to content

chore: Comet CI with Iceberg 1.9.1 #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
hsiang-c wants to merge 4 commits into from
Closed

chore: Comet CI with Iceberg 1.9.1 #1950

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7d04845
Set up CI for Iceberg 1.9.1 and Spark 3.4.4
hsiang-c Jun 27, 2025
1abf451
Remove Spark 3.4.4
hsiang-c Jun 29, 2025
cfff29b
Remove diff and revert snapshot version
hsiang-c Jun 29, 2025
505d711
Applied https://github.com/apache/datafusion-comet/pull/1985 to Icebe…
hsiang-c Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/actions/setup-spark-local-jar/action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ runs:
cd apache-spark
git apply ../dev/diffs/${{inputs.spark-version}}.diff
./dev/change-scala-version.sh ${{inputs.scala-version}}
./build/mvn versions:set -DnewVersion=${{inputs.spark-version}}-SNAPSHOT
./build/mvn versions:set -DnewVersion=${{inputs.spark-version}}-SNAPSHOT -DgenerateBackupPoms=false
./build/mvn -Pscala-${{inputs.scala-version}} -Phive -Phive-thriftserver -DskipTests -Denforcer.skip=true clean install
4 changes: 2 additions & 2 deletions .github/workflows/iceberg_spark_test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ jobs:
matrix:
os: [ubuntu-24.04]
java-version: [11, 17]
iceberg-version: [{short: '1.8', full: '1.8.1'}]
spark-version: [{short: '3.5', full: '3.5.6'}]
iceberg-version: [{short: '1.8', full: '1.8.1'}, {short: '1.9', full: '1.9.1'}]
spark-version: [{short: '3.4', full: '3.4.4'}, {short: '3.5', full: '3.5.6'}]
Copy link
Contributor Author

@hsiang-c hsiang-c Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use Spark 3.4.4 instead of 3.4.3 b/c Iceberg 1.9.1 depends on it: https://github.com/apache/iceberg/blob/apache-iceberg-1.9.1/gradle/libs.versions.toml#L82

Copy link
Contributor

@kazuyukitanimura kazuyukitanimura Jun 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I do not think we need to test Spark 3.4.4 with Iceberg 1.9.1 then.
3.4.4 is not tested for any other locations https://datafusion.apache.org/comet/user-guide/installation.html#supported-spark-versions
Let's remove 3.4.4

scala-version: ['2.13']
fail-fast: false
name: iceberg-spark-sql/${{ matrix.os }}/iceberg-${{ matrix.iceberg-version.full }}/spark-${{ matrix.spark-version.full }}/scala-${{ matrix.scala-version }}/java-${{ matrix.java-version }}
Expand Down
Loading
Loading