feat: implement_comet_native_lpad_expr #2102
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comphead
reviewed
Aug 10, 2025
There was a problem hiding this comment.
Thanks @coderfender This function might be a good candidate for https://github.com/apache/datafusion/tree/main/datafusion/spark/src/function
coderfender
changed the title
coderfender
changed the title
|
@mbutrovich , Once the PR #2099 is merged, I plan to change code in this branch to leverage the same class since most of the code for rpad could be leveraged to support lpad operation as well |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2101
Closes #.
Rationale for this change
Moving towards goal to support more native operations and not fallback to spark .
What changes are included in this PR?
How are these changes tested?
Unit tests in comet expression suite
If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
-->