Skip to content

fix: add_cast_compatibility_comet_long_decimal #2160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −3
Draft

fix: add_cast_compatibility_comet_long_decimal #2160

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/source/user-guide/compatibility.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ The following cast operations are generally compatible with Spark except for the
| long | integer | |
| long | float | |
| long | double | |
| long | decimal | |
| long | string | |
| float | boolean | |
| float | byte | |
Expand Down Expand Up @@ -212,7 +213,6 @@ The following cast operations are not compatible with Spark for all inputs and a
| From Type | To Type | Notes |
|-|-|-|
| integer | decimal | No overflow check |
| long | decimal | No overflow check |
| float | decimal | There can be rounding differences |
| double | decimal | There can be rounding differences |
| string | float | Does not support inputs ending with 'd' or 'f'. Does not support 'inf'. Does not support ANSI mode. |
Expand Down
4 changes: 3 additions & 1 deletion spark/src/main/scala/org/apache/comet/expressions/CometCast.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,12 @@ object CometCast {
Compatible()
case DataTypes.ByteType | DataTypes.ShortType | DataTypes.IntegerType =>
Compatible()
case DataTypes.FloatType | DataTypes.DoubleType =>
case d: DecimalType if(d.scale == 0 && d.precision == 19) =>
Compatible()
case _: DecimalType =>
Incompatible(Some("No overflow check"))
case DataTypes.FloatType | DataTypes.DoubleType =>
Compatible()
case _ =>
Unsupported
}
Expand Down
2 changes: 1 addition & 1 deletion spark/src/test/scala/org/apache/comet/CometExpressionSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ class CometExpressionSuite extends CometTestBase with AdaptiveSparkPlanHelper {

test("Integral Division Overflow Handling Matches Spark Behavior") {
withTable("t1") {
withSQLConf(CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key -> "true") {
withSQLConf(CometConf.COMET_CAST_ALLOW_INCOMPATIBLE.key -> "false") {
val value = Long.MinValue
sql("create table t1(c1 long, c2 short) using parquet")
sql(s"insert into t1 values($value, -1)")
Expand Down