Skip to content

Conversation

@hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Aug 16, 2025

  • Document current limitation

Which issue does this PR close?

Closes #. #2092

Rationale for this change

Comet and Iceberg integration is still WIP. We identified several issues that can be bypassed by configurations. Therefore, updated the docs to make these configurations clear to users.

What changes are included in this PR?

How are these changes tested?

Tested by Iceberg Spark tests w/ Comet enabled: #1987

@hsiang-c hsiang-c marked this pull request as ready for review August 18, 2025 16:31
--conf spark.memory.offHeap.size=2g \
--conf spark.comet.use.lazyMaterialization=false \
--conf spark.comet.schemaEvolution.enabled=true \
--conf spark.sql.adaptive.enabled=false # or spark.comet.exec.broadcastExchange.enabled=false, see `Known issues`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather not have this here. Users that do not need this workaround may copy and paste from here and will lose functionality unnecessarily

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hsiang-c

@parthchandra parthchandra merged commit 7b85d03 into apache:main Aug 19, 2025
@hsiang-c hsiang-c deleted the iceberg_doc branch August 19, 2025 19:39
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
* Update confs to bypass Iceberg Spark issues
 - Document current limitation

* Update iceberg.md

* Users can diable Spark's AQE as well

* Let users turn off AQE or Comet's broadcastExchange
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants