Skip to content

fix: remove fallback for int8 and int16 types with native Parquet readers #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+0 −6
Open

fix: remove fallback for int8 and int16 types with native Parquet readers #2197

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 0 additions & 6 deletions spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,12 +325,6 @@ case class CometScanTypeChecker(scanImpl: String) extends DataTypeSupport {
name: String,
fallbackReasons: ListBuffer[String]): Boolean = {
dt match {
case ByteType | ShortType
if scanImpl != CometConf.SCAN_NATIVE_COMET &&
!CometConf.COMET_SCAN_ALLOW_INCOMPATIBLE.get() =>
fallbackReasons += s"$scanImpl scan cannot read $dt when " +
s"${CometConf.COMET_SCAN_ALLOW_INCOMPATIBLE.key} is false. ${CometConf.COMPAT_GUIDE}."
false
case _: StructType | _: ArrayType | _: MapType if scanImpl == CometConf.SCAN_NATIVE_COMET =>
false
case _ =>
Expand Down
Loading