chore: Refactor Cast serde to avoid code duplication
#2242
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2242 +/- ##
=============================================
- Coverage 56.12% 44.08% -12.04%
- Complexity 976 1077 +101
=============================================
Files 119 145 +26
Lines 11743 13330 +1587
Branches 2251 2370 +119
=============================================
- Hits 6591 5877 -714
- Misses 4012 6447 +2435
+ Partials 1140 1006 -134 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
Cast serde [WIP]Cast serde to avoid code duplication
comphead
reviewed
Aug 27, 2025
| "Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled", | ||
| "make_interval is not supported")), | ||
| "Cast from CalendarIntervalType to String is not supported", | ||
| "Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled")), |
There was a problem hiding this comment.
Suggested change
| "Comet shuffle is not enabled: spark.comet.exec.shuffle.enabled is not enabled")), | |
| "Comet shuffle is not enabled. To enable set spark.comet.exec.shuffle.enabled")), |
There was a problem hiding this comment.
This message comes from CometExecRule. The message format wasn't modified as part of this PR, so changing the expected message here seems out of scope for this PR?
comphead
reviewed
Aug 27, 2025
spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Oleks V <[email protected]>
comphead
reviewed
Aug 27, 2025
| @@ -136,7 +187,7 @@ object CometCast { | |||
| // https://github.com/apache/datafusion-comet/issues/328 | |||
| Incompatible(Some("Not all valid formats are supported")) | |||
| case _ => | |||
| Unsupported | |||
| Unsupported(Some(s"Cast from String to $toType is not supported")) | |||
There was a problem hiding this comment.
can see lots of Unsupported(Some(s"Cast from String to $toType is not supported")), canthis be a helper function?
def unsupportedCast(from, to) {
Unsupported(Some(s"Cast from $from to $to is not supported"))
}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2239
Part of #2019
Rationale for this change
Make
Casta standard Comet expression that implementsCometExpressionSerderather than have special handling inQueryPlanSerde.What changes are included in this PR?
COMET_CAST_ALLOW_INCOMPATIBLEconfig.COMET_EXPR_ALLOW_INCOMPATIBLEis used instead.How are these changes tested?