Skip to content

Conversation

wForget
Copy link
Member

@wForget wForget commented Sep 1, 2025

Which issue does this PR close?

Closes #2271.

Rationale for this change

Currently we prefer to use jvm-based libhdfs to implement native hdfs reader, which means we can support more hadoop file systems. But currently we hardcode to support only hdfs scheme, I want to make the supported hadoop file system schemes configurable.

What changes are included in this PR?

Make supported hadoop filesystem schemes configurable

How are these changes tested?

After patch #2244, the newly added test cases were successfully run

@codecov-commenter
Copy link

codecov-commenter commented Sep 1, 2025

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.74%. Comparing base (f09f8af) to head (13cb948).
⚠️ Report is 434 commits behind head on main.

Files with missing lines Patch % Lines
...la/org/apache/comet/objectstore/NativeConfig.scala 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2272      +/-   ##
============================================
+ Coverage     56.12%   57.74%   +1.61%     
- Complexity      976     1291     +315     
============================================
  Files           119      145      +26     
  Lines         11743    13364    +1621     
  Branches       2251     2379     +128     
============================================
+ Hits           6591     7717    +1126     
- Misses         4012     4390     +378     
- Partials       1140     1257     +117     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wForget wForget marked this pull request as ready for review September 2, 2025 02:15
@comphead
Copy link
Contributor

comphead commented Sep 2, 2025

@parthchandra cc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support additional hadoop file systems
3 participants