Skip to content

Conversation

hsiang-c
Copy link
Contributor

@hsiang-c hsiang-c commented Sep 1, 2025

Which issue does this PR close?

Closes #. #1854

Rationale for this change

What changes are included in this PR?

  • Add BooleanType for both functions.
  • Add TimestampNTZType to can_rank function.
  • Support sorting MapType on its values
  • Move existing temporal types to a separate case clause
  • Exclude Spark's YearMonthIntervalType and DayTimeIntervalType for now b/c Comet is disabled in SparkPlan with either type.
  • Align Comet's canRank/can_sort_to_indices function w/ Arrow's can_rank and can_sort_to_indices

How are these changes tested?

  • Tested by sorting on Array/Map of previous unsupported types
  • Make sure CometSort is in the SparkPlan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant