Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Sep 4, 2025

Which issue does this PR close?

Closes #2303

We need to merge #2359 first

Rationale for this change

We have to manually add new tests suites to the CI workflows, and sometimes we forget.

What changes are included in this PR?

How are these changes tested?

See https://github.com/apache/datafusion-comet/actions/runs/17468541728/job/49610635640?pr=2304

@andygrove andygrove marked this pull request as ready for review September 4, 2025 15:14
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 57.62%. Comparing base (f09f8af) to head (e654c72).
⚠️ Report is 485 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2304      +/-   ##
============================================
+ Coverage     56.12%   57.62%   +1.49%     
- Complexity      976     1297     +321     
============================================
  Files           119      147      +28     
  Lines         11743    13497    +1754     
  Branches       2251     2390     +139     
============================================
+ Hits           6591     7777    +1186     
- Misses         4012     4451     +439     
- Partials       1140     1269     +129     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @andygrove

@andygrove andygrove marked this pull request as draft September 9, 2025 23:25
@andygrove
Copy link
Member Author

We need to merge #2359 and then merge this one

@andygrove andygrove marked this pull request as ready for review September 10, 2025 01:36
@andygrove andygrove merged commit 65bbe43 into apache:main Sep 10, 2025
136 of 137 checks passed
@andygrove andygrove deleted the check-missing-suites branch September 10, 2025 05:06
andygrove added a commit to andygrove/datafusion-comet that referenced this pull request Sep 10, 2025
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI check that all Scala test suites are part of the PR workflows

4 participants