chore: Refactor Literal serde #2377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2377 +/- ##
============================================
+ Coverage 56.12% 57.43% +1.30%
- Complexity 976 1296 +320
============================================
Files 119 147 +28
Lines 11743 13405 +1662
Branches 2251 2346 +95
============================================
+ Hits 6591 7699 +1108
- Misses 4012 4443 +431
- Partials 1140 1263 +123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wForget
reviewed
Sep 11, 2025
| exprBuilder.setListVal(listLiteralBuilder.build()) | ||
| exprBuilder.setDatatype(serializeDataType(dataType).get) | ||
| case dt => | ||
| logWarning(s"Unexpected datatype '$dt' for literal value '$value'") |
Member
There was a problem hiding this comment.
Would it be better to throw an exception here?
Member
Author
There was a problem hiding this comment.
Yes, I think so. Thanks, I will update this.
Member
Author
There was a problem hiding this comment.
I updated this code to tag the plan with the warning and fall back to Spark
Contributor
|
Some compilation errors? |
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2019
Rationale for this change
What changes are included in this PR?
How are these changes tested?