Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Sep 10, 2025

Which issue does this PR close?

Part of #2019

Rationale for this change

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Sep 10, 2025

Codecov Report

❌ Patch coverage is 75.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 57.64%. Comparing base (f09f8af) to head (bf4cb18).
⚠️ Report is 490 commits behind head on main.

Files with missing lines Patch % Lines
...main/scala/org/apache/comet/serde/arithmetic.scala 72.72% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2378      +/-   ##
============================================
+ Coverage     56.12%   57.64%   +1.52%     
- Complexity      976     1296     +320     
============================================
  Files           119      147      +28     
  Lines         11743    13513    +1770     
  Branches       2251     2389     +138     
============================================
+ Hits           6591     7790    +1199     
- Misses         4012     4453     +441     
- Partials       1140     1270     +130     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @andygrove

@andygrove andygrove merged commit 2811793 into apache:main Sep 11, 2025
98 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants