chore: [iceberg] support Iceberg 1.9.1 #2386
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2386 +/- ##
============================================
+ Coverage 56.12% 57.42% +1.30%
- Complexity 976 1296 +320
============================================
Files 119 147 +28
Lines 11743 13415 +1672
Branches 2251 2347 +96
============================================
+ Hits 6591 7704 +1113
- Misses 4012 4449 +437
- Partials 1140 1262 +122 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| relocate 'com.thoughtworks.paranamer', 'org.apache.iceberg.shaded.com.thoughtworks.paranamer' | ||
| - relocate 'org.apache.parquet', 'org.apache.iceberg.shaded.org.apache.parquet' | ||
| - relocate 'shaded.parquet', 'org.apache.iceberg.shaded.org.apache.parquet.shaded' | ||
| +// relocate 'org.apache.parquet', 'org.apache.iceberg.shaded.org.apache.parquet' |
There was a problem hiding this comment.
should we be keeping the original shaded versions to catch any regression here?
There was a problem hiding this comment.
@parthchandra I think you're right since it has been resolved by your work. I'll open a PR to address it.
There was a problem hiding this comment.
@parthchandra I think you're right since it has been resolved by your work. I'll open a PR to address it.
Not quite. I re-introduced the relocation and found one more place where shading is broken and a second place where the unit test fails. Looking into it as part of apache/iceberg#13378
4 participants
Which issue does this PR close?
Partially closes #. #2380
Rationale for this change
1.9.1What changes are included in this PR?
1.9.1How are these changes tested?
iceberg-spark,iceberg-spark-extensionsandiceberg-spark-runtimeall passed locally.