minor: Update TPC-DS microbenchmarks to remove "scan only" and "exec only" runs #2396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2396 +/- ##
============================================
+ Coverage 56.12% 57.52% +1.39%
- Complexity 976 1296 +320
============================================
Files 119 147 +28
Lines 11743 13476 +1733
Branches 2251 2354 +103
============================================
+ Hits 6591 7752 +1161
- Misses 4012 4459 +447
- Partials 1140 1265 +125 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
commented
Sep 17, 2025
| nameSuffix: String = ""): Unit = { | ||
| queries.foreach { name => | ||
| val source = Source.fromFile(s"spark/src/test/resources/tpcds-micro-benchmarks/$name.sql") | ||
| val source = Source.fromFile(s"src/test/resources/tpcds-micro-benchmarks/$name.sql") |
Member
Author
There was a problem hiding this comment.
I had to modify the path to get the benchmark working from the command-line
parthchandra
approved these changes
Sep 19, 2025
Contributor
parthchandra
left a comment
parthchandra
left a comment
There was a problem hiding this comment.
lgtm. Some operations appear to be slower in Comet per these results (though that's a different problem).
coderfender
pushed a commit
to coderfender/datafusion-comet
that referenced
this pull request
Dec 13, 2025
…only" runs (apache#2396) * save * Minor cleanup of TPC-DS microbenchmarks * revert * prep for review * prep for review * prep for review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
There no longer seems to be any value in running Comet microbenchmarks in "scan only" or "exec only" mode.
What changes are included in this PR?
Just run Spark vs Comet comparison.
How are these changes tested?
I ran the benchmarks locally against the 100GB dataset.