Skip to content

Conversation

@kazantsev-maksim
Copy link
Contributor

Which issue does this PR close?

Part of: #2443

Rationale for this change

Part of: #2443

What changes are included in this PR?

How are these changes tested?

Tested with existing unit tests

@codecov-commenter
Copy link

codecov-commenter commented Sep 28, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.38%. Comparing base (f09f8af) to head (2fdf93c).
⚠️ Report is 561 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2473      +/-   ##
============================================
+ Coverage     56.12%   58.38%   +2.25%     
- Complexity      976     1436     +460     
============================================
  Files           119      146      +27     
  Lines         11743    13502    +1759     
  Branches       2251     2350      +99     
============================================
+ Hits           6591     7883    +1292     
- Misses         4012     4389     +377     
- Partials       1140     1230      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wForget
Copy link
Member

wForget commented Sep 29, 2025

Looks like a related failure:

- date_sub with scalar overflow *** FAILED *** (175 milliseconds)
  "[EXPRESSION_DECODING_FAILED] Failed to decode a row to a value of the expressions: createexternalrow(static_invoke(DateTimeUtils.toJavaDate(input[0, date, true])), StructField(date_sub(_20, 2147483647),DateType,true)). SQLSTATE: 42846" did not contain "integer overflow" (CometExpressionSuite.scala:302)

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andygrove andygrove merged commit 83d951d into apache:main Oct 1, 2025
102 checks passed
@kazantsev-maksim kazantsev-maksim deleted the date_add_sub_to_datafusion_impl branch November 27, 2025 05:33
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
…e#2473)

* Date_add and date_sub to DataFusion impl

* Fix tests

---------

Co-authored-by: Kazantsev Maksim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants