Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Oct 1, 2025

Which issue does this PR close?

Fix regression introduced in #2491

Rationale for this change

Script fails without this fix

What changes are included in this PR?

How are these changes tested?

@andygrove andygrove requested a review from comphead October 1, 2025 17:23
Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouch, thanks for finding this

@codecov-commenter
Copy link

codecov-commenter commented Oct 1, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.38%. Comparing base (f09f8af) to head (f03ee81).
⚠️ Report is 562 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2512      +/-   ##
============================================
+ Coverage     56.12%   58.38%   +2.25%     
- Complexity      976     1436     +460     
============================================
  Files           119      146      +27     
  Lines         11743    13502    +1759     
  Branches       2251     2350      +99     
============================================
+ Hits           6591     7883    +1292     
- Misses         4012     4389     +377     
- Partials       1140     1230      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove merged commit 828642a into apache:main Oct 1, 2025
106 checks passed
@andygrove andygrove deleted the fix-tpcbench branch October 1, 2025 19:12
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants