-
Notifications
You must be signed in to change notification settings - Fork 268
feat: Add backtrace feature to simplify enabling native backtraces in CometNativeException
#2515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2515 +/- ##
============================================
+ Coverage 56.12% 58.49% +2.36%
- Complexity 976 1447 +471
============================================
Files 119 146 +27
Lines 11743 13550 +1807
Branches 2251 2356 +105
============================================
+ Hits 6591 7926 +1335
- Misses 4012 4390 +378
- Partials 1140 1234 +94 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
FWIW, there is also datafusion-comet/native/core/src/errors.rs Line 130 in 07393c1
|
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove
Its been a while since backtraces introduced in DF and I was thinking to replace Comet errors with DFs? So they would have backtrace capabilities and would be easier to navigate through Comet and DF, WDYT?
I don't know enough about this. Would you mind writing up an issue to explain in more detail? |
DataFusion uses error macros (for example But what comes to my mind now is: DF backtrace should include Comet entrypoint anyway, because it is caller code, so we don't really need to use error macros in Comet. |
…in `CometNativeException` (apache#2515)
Which issue does this PR close?
N/A
Rationale for this change
Making life simpler when debugging. We previously asked developers to modify the
Cargo.tomlfile. I just exposed thebacktracefeature instead.What changes are included in this PR?
Expose
backtracefeature. Update docs.How are these changes tested?