Skip to content

fix: [branch-0.10][iceberg] Close reader instance in ReadConf #2535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andygrove merged 1 commit into from
Oct 6, 2025
Merged

fix: [branch-0.10][iceberg] Close reader instance in ReadConf #2535

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions dev/diffs/iceberg/1.8.1.diff
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ index 7327b38905d..7967109f039 100644
exclude group: 'org.apache.avro', module: 'avro'
// already shaded by Parquet
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
index 04ffa8f4edc..cc0099ccc93 100644
index 04ffa8f4edc..a909cd552c1 100644
--- a/gradle/libs.versions.toml
+++ b/gradle/libs.versions.toml
@@ -34,6 +34,7 @@ azuresdk-bom = "1.2.31"
Expand Down Expand Up @@ -300,10 +300,10 @@ index 00000000000..ddf6c7de5ae
+}
diff --git a/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java b/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java
new file mode 100644
index 00000000000..88b195b76a2
index 00000000000..a3cba401827
--- /dev/null
+++ b/parquet/src/main/java/org/apache/iceberg/parquet/CometVectorizedParquetReader.java
@@ -0,0 +1,255 @@
@@ -0,0 +1,260 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
Expand Down Expand Up @@ -446,6 +446,7 @@ index 00000000000..88b195b76a2
+ private long valuesRead = 0;
+ private T last = null;
+ private final FileReader cometReader;
+ private ReadConf conf;
+
+ FileIterator(
+ ReadConf conf,
Expand All @@ -470,6 +471,7 @@ index 00000000000..88b195b76a2
+ length,
+ fileEncryptionKey,
+ fileAADPrefix);
+ this.conf = conf;
+ }
+
+ private FileReader newCometReader(
Expand Down Expand Up @@ -556,6 +558,9 @@ index 00000000000..88b195b76a2
+ public void close() throws IOException {
+ model.close();
+ cometReader.close();
+ if (conf != null && conf.reader() != null) {
+ conf.reader().close();
+ }
+ }
+ }
+}
Expand Down
Loading
Loading