Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

Closes #2540

Rationale for this change

See #2540

What changes are included in this PR?

How are these changes tested?

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.92%. Comparing base (f09f8af) to head (628d16f).
⚠️ Report is 581 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2541      +/-   ##
============================================
+ Coverage     56.12%   58.92%   +2.79%     
- Complexity      976     1457     +481     
============================================
  Files           119      147      +28     
  Lines         11743    13642    +1899     
  Branches       2251     2369     +118     
============================================
+ Hits           6591     8038    +1447     
- Misses         4012     4381     +369     
- Partials       1140     1223      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review October 9, 2025 15:03
@andygrove andygrove requested a review from mbutrovich October 9, 2025 15:40
@andygrove andygrove changed the title fix: Run scala tests against release build of native code build: Run scala tests against release build of native code Oct 9, 2025
Copy link
Contributor

@mbutrovich mbutrovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this replace an existing CI check? I think we'd want to run in both debug and release (in case we start making more use of things like debug_assert).

Copy link
Contributor

@parthchandra parthchandra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@parthchandra
Copy link
Contributor

Does this replace an existing CI check? I think we'd want to run in both debug and release (in case we start making more use of things like debug_assert).

One option is to parametrize this pipeline and run with the release build only before a release. That increases the burden on the release manager though.

@andygrove
Copy link
Member Author

Does this replace an existing CI check? I think we'd want to run in both debug and release (in case we start making more use of things like debug_assert).

I'd like to go ahead and merge this to unblock some things. I filed a follow-on issue #2544 to discuss this

@andygrove andygrove merged commit cd29597 into apache:main Oct 10, 2025
113 of 114 checks passed
@andygrove andygrove deleted the test-release-build branch October 10, 2025 15:04
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CI workflow to run tests using release build of native code

4 participants