-
Notifications
You must be signed in to change notification settings - Fork 277
build: Run scala tests against release build of native code #2541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2541 +/- ##
============================================
+ Coverage 56.12% 58.92% +2.79%
- Complexity 976 1457 +481
============================================
Files 119 147 +28
Lines 11743 13642 +1899
Branches 2251 2369 +118
============================================
+ Hits 6591 8038 +1447
- Misses 4012 4381 +369
- Partials 1140 1223 +83 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this replace an existing CI check? I think we'd want to run in both debug and release (in case we start making more use of things like debug_assert).
parthchandra
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
One option is to parametrize this pipeline and run with the release build only before a release. That increases the burden on the release manager though. |
I'd like to go ahead and merge this to unblock some things. I filed a follow-on issue #2544 to discuss this |
Which issue does this PR close?
Closes #2540
Rationale for this change
See #2540
What changes are included in this PR?
How are these changes tested?