chore: [iceberg] test iceberg 1.10.0 #2709
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuzhang
force-pushed
the
test-iceberg-1.10
branch
from
cc5d220 to
f7134e0
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2709 +/- ##
============================================
+ Coverage 56.12% 59.33% +3.20%
- Complexity 976 1448 +472
============================================
Files 119 147 +28
Lines 11743 13819 +2076
Branches 2251 2372 +121
============================================
+ Hits 6591 8199 +1608
- Misses 4012 4391 +379
- Partials 1140 1229 +89 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
manuzhang
changed the title
manuzhang
force-pushed
the
test-iceberg-1.10
branch
from
f7134e0 to
ac60b7c
Compare
manuzhang
force-pushed
the
test-iceberg-1.10
branch
from
ac60b7c to
c5013d8
Compare
Contributor
|
@hsiang-c mind taking a look? |
hsiang-c
reviewed
Nov 7, 2025
| + model.close(); | ||
| + cometReader.close(); | ||
| + if (conf != null && conf.reader() != null) { | ||
| + conf.reader().close(); |
hsiang-c
approved these changes
Nov 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2703.
Rationale for this change
What changes are included in this PR?
How are these changes tested?