feat: Run Spark SQL tests with spark.comet.sparkToColumnar.enabled=true
#2714
+32
−65
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2714 +/- ##
============================================
+ Coverage 56.12% 58.45% +2.33%
- Complexity 976 1456 +480
============================================
Files 119 159 +40
Lines 11743 13892 +2149
Branches 2251 2375 +124
============================================
+ Hits 6591 8121 +1530
- Misses 4012 4570 +558
- Partials 1140 1201 +61 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
spark.comet.sparkToColumnar.enabled=truespark.comet.sparkToColumnar.enabled=true
andygrove
changed the title
spark.comet.sparkToColumnar.enabled=truespark.comet.sparkToColumnar.enabled=true
andygrove
force-pushed
the
test-spark-sql-coverage
branch
from
086e9fb to
cdec3ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2723
Rationale for this change
Many (most?) Spark SQL tests do not start with Parquet scan, so Comet falls back early. Enabling
spark.comet.sparkToColumnar.enabledresults in greater test coverage for Comet.What changes are included in this PR?
How are these changes tested?