-
Notifications
You must be signed in to change notification settings - Fork 249
chore: Operator serde refactor part 2 #2741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2741 +/- ##
============================================
+ Coverage 56.12% 58.62% +2.49%
- Complexity 976 1465 +489
============================================
Files 119 163 +44
Lines 11743 13987 +2244
Branches 2251 2377 +126
============================================
+ Hits 6591 8200 +1609
- Misses 4012 4580 +568
- Partials 1140 1207 +67 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
mbutrovich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove!
|
Thanks @mbutrovich! |
Which issue does this PR close?
N/A
Builds on the changes in part 1 - #2738
Rationale for this change
What changes are included in this PR?
WindowExecto theopSerdeMap. I have a follow up PR fix: MarkWindowExecas incompatible [WIP] #2736 to also addWindowExecgetSupportLeveltoCometOperatorSerdeto match the approach used with expressions. The follow up PR actually implementsgetSupportLevelforWindowExecorg.apache.comet.serde.operatorpackage. Some were moved in Feat: Add CometLocalTableScanExec operator #2735How are these changes tested?