Skip to content

Conversation

@andygrove
Copy link
Member

Which issue does this PR close?

Follows on from #2741

Rationale for this change

Remove temp fallback and use CometOperatorSerde framework instead

What changes are included in this PR?

  • Remove temp fallback and use CometOperatorSerde framework instead
  • Remove support for WindowsExec as a Comet sink because it causes panics
  • Update golden files

How are these changes tested?

case _: CollectLimitExec => true
case _: UnionExec => true
case _: TakeOrderedAndProjectExec => true
case _: WindowExec => true
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line fixes #2737. I wish I could explain why, but I cannot.

@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2025

Codecov Report

❌ Patch coverage is 39.39394% with 40 lines in your changes missing coverage. Please review.
✅ Project coverage is 45.89%. Comparing base (f09f8af) to head (50c5972).
⚠️ Report is 680 commits behind head on main.

Files with missing lines Patch % Lines
.../scala/org/apache/comet/serde/QueryPlanSerde.scala 42.85% 25 Missing and 7 partials ⚠️
...on/src/main/scala/org/apache/comet/CometConf.scala 20.00% 4 Missing ⚠️
...in/scala/org/apache/comet/serde/SupportLevel.scala 0.00% 3 Missing ⚠️
.../org/apache/comet/serde/operator/CometWindow.scala 0.00% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##               main    #2748       +/-   ##
=============================================
- Coverage     56.12%   45.89%   -10.24%     
- Complexity      976     1219      +243     
=============================================
  Files           119      163       +44     
  Lines         11743    13984     +2241     
  Branches       2251     2375      +124     
=============================================
- Hits           6591     6418      -173     
- Misses         4012     6525     +2513     
+ Partials       1140     1041       -99     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove andygrove marked this pull request as ready for review November 10, 2025 00:04
@andygrove andygrove marked this pull request as draft November 10, 2025 00:30
@andygrove andygrove changed the title fix: Mark WindowsExec as incompatible fix: Mark WindowsExec as incompatible [WIP] Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants