-
Notifications
You must be signed in to change notification settings - Fork 249
fix: Mark WindowsExec as incompatible [WIP]
#2748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
| case _: CollectLimitExec => true | ||
| case _: UnionExec => true | ||
| case _: TakeOrderedAndProjectExec => true | ||
| case _: WindowExec => true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing this line fixes #2737. I wish I could explain why, but I cannot.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2748 +/- ##
=============================================
- Coverage 56.12% 45.89% -10.24%
- Complexity 976 1219 +243
=============================================
Files 119 163 +44
Lines 11743 13984 +2241
Branches 2251 2375 +124
=============================================
- Hits 6591 6418 -173
- Misses 4012 6525 +2513
+ Partials 1140 1041 -99 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
WindowsExec as incompatibleWindowsExec as incompatible [WIP]
Which issue does this PR close?
Follows on from #2741
Rationale for this change
Remove temp fallback and use
CometOperatorSerdeframework insteadWhat changes are included in this PR?
CometOperatorSerdeframework insteadWindowsExecas a Comet sink because it causes panicsHow are these changes tested?