Skip to content

Conversation

@andygrove
Copy link
Member

@andygrove andygrove commented Nov 16, 2025

Which issue does this PR close?

N/A

Rationale for this change

Running make regenerates configs.md without prettier formatting, resulting in a local diff that will fail CI if pushed and requires the user to run prettier as well.

Another issue is that after this process, the diff does not clearly show which config was added or removed, because the entire table gets rewritten.

This PR adds prettier tags around tables to turn off linting for those sections.

What changes are included in this PR?

How are these changes tested?

@andygrove andygrove marked this pull request as ready for review November 16, 2025 16:10
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.27%. Comparing base (f09f8af) to head (f677325).
⚠️ Report is 706 commits behind head on main.

Files with missing lines Patch % Lines
...src/main/scala/org/apache/comet/GenerateDocs.scala 0.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2790      +/-   ##
============================================
+ Coverage     56.12%   58.27%   +2.15%     
- Complexity      976     1422     +446     
============================================
  Files           119      157      +38     
  Lines         11743    14122    +2379     
  Branches       2251     2365     +114     
============================================
+ Hits           6591     8230    +1639     
- Misses         4012     4701     +689     
- Partials       1140     1191      +51     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wForget wForget left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andygrove

@andygrove andygrove merged commit d47f196 into apache:main Nov 17, 2025
105 checks passed
coderfender pushed a commit to coderfender/datafusion-comet that referenced this pull request Dec 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants