Skip to content

Conversation

@mbutrovich
Copy link
Contributor

@mbutrovich mbutrovich commented Dec 12, 2025

Which issue does this PR close?

Closes #1719.

Rationale for this change

What changes are included in this PR?

If this partition's list of files is empty, use DataFusion's EmptyExec instead of instantiating a DataSourceExec.

How are these changes tested?

New test. CometExecSuite runs with CometConf.COMET_NATIVE_SCAN_IMPL.key -> CometConf.SCAN_AUTO but I set it to SCAN_NATIVE_DATAFUSION and confirmed that it was using the fully-native scan and passed the test.

@mbutrovich mbutrovich changed the title feat: Enable bucket pruning with native_datafusion by using EmptyExec when no files for this partition feat: Enable bucket pruning with native_datafusion Dec 12, 2025
@mbutrovich mbutrovich changed the title feat: Enable bucket pruning with native_datafusion feat: Enable bucket pruning with native_datafusion scans Dec 12, 2025
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.43%. Comparing base (f09f8af) to head (17876f7).
⚠️ Report is 758 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2888      +/-   ##
============================================
+ Coverage     56.12%   59.43%   +3.31%     
- Complexity      976     1376     +400     
============================================
  Files           119      167      +48     
  Lines         11743    15335    +3592     
  Branches       2251     2548     +297     
============================================
+ Hits           6591     9115    +2524     
- Misses         4012     4935     +923     
- Partials       1140     1285     +145     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@andygrove
Copy link
Member

Could you also update contributor-guide/parquet_scans.html

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Thanks @mbutrovich

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mbutrovich one more limitation is gone

@mbutrovich mbutrovich merged commit 7282d57 into apache:main Dec 12, 2025
114 checks passed
@mbutrovich mbutrovich deleted the native_datafusion_bucket_pruning branch December 12, 2025 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat: bucketed scan for native_datafusion Parquet scan

4 participants