Skip to content

fix: array to array cast #2897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
manuzhang wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: array to array cast #2897

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,4 @@ apache-rat-*.jar
venv
dev/release/comet-rm/workdir
spark/benchmarks
/comet-event-trace.json
18 changes: 16 additions & 2 deletions native/spark-expr/src/conversion_funcs/cast.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1076,8 +1076,22 @@ fn cast_array(
cast_options,
)?),
(List(_), Utf8) => Ok(cast_array_to_string(array.as_list(), cast_options)?),
(List(_), List(_)) if can_cast_types(from_type, to_type) => {
Ok(cast_with_options(&array, to_type, &CAST_OPTIONS)?)
(List(from), List(to))
if can_cast_types(from_type, to_type)
|| (matches!(from.data_type(), Decimal128(_, _))
Copy link
Contributor

@parthchandra parthchandra Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this the only case where we have a spark cast but no DF/arrow cast?

&& matches!(to.data_type(), Boolean)) =>
{
let list_array = array.as_list::<i32>();
Ok(Arc::new(ListArray::new(
Arc::clone(to),
list_array.offsets().clone(),
cast_array(
Arc::clone(list_array.values()),
to.data_type(),
cast_options,
)?,
list_array.nulls().cloned(),
)) as ArrayRef)
}
(UInt8 | UInt16 | UInt32 | UInt64, Int8 | Int16 | Int32 | Int64)
if cast_options.allow_cast_unsigned_ints =>
Expand Down
28 changes: 26 additions & 2 deletions spark/src/test/scala/org/apache/comet/CometCastSuite.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1154,6 +1154,30 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
}
}

test("cast ArrayType to ArrayType") {
val types = Seq(
BooleanType,
StringType,
ByteType,
IntegerType,
LongType,
ShortType,
DecimalType(10, 2),
DecimalType(38, 18))
for (fromType <- types) {
for (toType <- types) {
if (fromType != toType &&
!tags
.get(s"cast $fromType to $toType")
.exists(s => s.contains("org.scalatest.Ignore")) &&
Cast.canCast(fromType, toType) &&
CometCast.isSupported(fromType, toType, None, CometEvalMode.LEGACY) == Compatible()) {
castTest(generateArrays(100, fromType), ArrayType(toType))
}
}
}
}

private def generateFloats(): DataFrame = {
withNulls(gen.generateFloats(dataSize)).toDF("a")
}
Expand Down Expand Up @@ -1182,10 +1206,10 @@ class CometCastSuite extends CometTestBase with AdaptiveSparkPlanHelper {
withNulls(gen.generateLongs(dataSize)).toDF("a")
}

private def generateArrays(rowSize: Int, elementType: DataType): DataFrame = {
private def generateArrays(rowNum: Int, elementType: DataType): DataFrame = {
Copy link
Contributor

@coderfender coderfender Jan 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit : might be an unintended change ?

Copy link
Member Author

@manuzhang manuzhang Jan 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intended since rowNum (meaning the number of rows) makes more sense to me.

import scala.collection.JavaConverters._
val schema = StructType(Seq(StructField("a", ArrayType(elementType), true)))
spark.createDataFrame(gen.generateRows(rowSize, schema).asJava, schema)
spark.createDataFrame(gen.generateRows(rowNum, schema).asJava, schema)
}

// https://github.com/apache/datafusion-comet/issues/2038
Expand Down
Loading