Skip to content

perf: Use await instead of block_on in native shuffle writer #2937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mbutrovich merged 1 commit into from
Dec 18, 2025
Merged

perf: Use await instead of block_on in native shuffle writer #2937

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions native/core/src/execution/shuffle/shuffle_writer.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ use datafusion::{
},
};
use datafusion_comet_spark_expr::hash_funcs::murmur3::create_murmur3_hashes;
use futures::executor::block_on;
use futures::{StreamExt, TryFutureExt, TryStreamExt};
use itertools::Itertools;
use std::borrow::Borrow;
Expand Down Expand Up @@ -254,11 +253,11 @@ async fn external_shuffle(
};

while let Some(batch) = input.next().await {
// Block on the repartitioner to insert the batch and shuffle the rows
// Await the repartitioner to insert the batch and shuffle the rows
// into the corresponding partition buffer.
// Otherwise, pull the next batch from the input stream might overwrite the
// current batch in the repartitioner.
block_on(repartitioner.insert_batch(batch?))?;
repartitioner.insert_batch(batch?).await?;
}

repartitioner.shuffle_write()?;
Expand Down
Loading