chore: Reduce timer overhead in native shuffle writer #2941
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andygrove
commented
Dec 19, 2025
| if num_rows >= self.batch_size || num_rows + self.num_buffered_rows > self.batch_size { | ||
| let concatenated_batch = self.concat_buffered_batches()?; | ||
|
|
||
| let write_start_time = Instant::now(); |
Member
Author
There was a problem hiding this comment.
Removing this one is actually a bug fix rather than an optimiation. The timer was already being passed into functions that perform the writes.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2941 +/- ##
============================================
+ Coverage 56.12% 59.60% +3.47%
- Complexity 976 1379 +403
============================================
Files 119 167 +48
Lines 11743 15428 +3685
Branches 2251 2550 +299
============================================
+ Hits 6591 9196 +2605
- Misses 4012 4946 +934
- Partials 1140 1286 +146 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #.
Rationale for this change
What changes are included in this PR?
write_timewas being double countedHow are these changes tested?