chore: Improve microbenchmark for string expressions #2964
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2964 +/- ##
============================================
+ Coverage 56.12% 59.62% +3.49%
- Complexity 976 1375 +399
============================================
Files 119 167 +48
Lines 11743 15488 +3745
Branches 2251 2567 +316
============================================
+ Hits 6591 9234 +2643
- Misses 4012 4956 +944
- Partials 1140 1298 +158 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andygrove
changed the title
comphead
reviewed
Jan 2, 2026
| withTempTable("parquetV1Table") { | ||
| prepareTable( | ||
| dir, | ||
| spark.sql(s"SELECT REPEAT(CAST(value AS STRING), 10) AS c1 FROM $tbl")) |
Contributor
There was a problem hiding this comment.
should we have random string lengths?
something like
SELECT
substring(
repeat(
value
20
),
cast(rand() * 26 as int) + 1,
cast(rand() * 20 as int) + 1
) AS random_string
FROM range(10);
Contributor
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
N/A
Rationale for this change
Make benchmarks faster to run and cover all string functions.
What changes are included in this PR?
Create the input data once instead of once per expression.
How are these changes tested?
Current benchmark results:
string.txt