-
Notifications
You must be signed in to change notification settings - Fork 268
build: Skip macOS Spark 4 fuzz test #2966
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@manuzhang I think we can just skip the "fuzz" suite and keep the other Spark 4 tests active for macOS |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2966 +/- ##
============================================
+ Coverage 56.12% 59.59% +3.47%
- Complexity 976 1381 +405
============================================
Files 119 167 +48
Lines 11743 15492 +3749
Branches 2251 2568 +317
============================================
+ Hits 6591 9233 +2642
- Misses 4012 4959 +947
- Partials 1140 1300 +160 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This failed test looks like a flaky one |
comphead
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andygrove
btw WDYT to optimize test process in future and start fuzz testing before the release only or if some specific files were changed?
That sounds great. Do you have an idea about how we can achieve this? |
We can take Datafusion examples https://github.com/apache/datafusion/blob/33ac70dd6d634da040cc34abd414425b176a2b99/.github/workflows/extended.yml#L43 so extended tests are triggered if PR is for release branch With latest PRs Comet modularity changes can open doors now for this test conditional trigger? |
Which issue does this PR close?
Workaround for #2965
Rationale for this change
This test is failing most of the time in all PR builds.
What changes are included in this PR?
How are these changes tested?