Skip to content

Fix verify-release-candidate script by removing reference to requirements-310.txt #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 5, 2025
Merged

Fix verify-release-candidate script by removing reference to requirements-310.txt #1012

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cc28263
Fix verify-release-candidate script by removing requirements.txt
alamb Feb 3, 2025
5775813
Update dev/release/verify-release-candidate.sh
alamb Feb 5, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,6 @@ test_source_distribution() {
python3 -m venv .venv
source .venv/bin/activate
python3 -m pip install -U pip
python3 -m pip install -r requirements-310.txt
Copy link
Member

@viirya viirya Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to add python3 -m pip install -U maturin to make the verify script work locally.

Copy link
Contributor

@kevinjqliu kevinjqliu Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that makes sense, we create and activate a new venv right above

Looks like requirements-310.txt was removed in #994

maturin develop

#TODO: we should really run tests here as well
Expand Down