Skip to content

refactor: collect dataframe as stream in __repr__ #1015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

refactor: collect dataframe as stream in __repr__ #1015

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
d65609a
Use stream in repr to truncate rows
konjac Feb 5, 2025
b218692
Merge branch 'main' of https://github.com/apache/datafusion-python in…
konjac Feb 5, 2025
51fdc12
Fix bug by moving take(10) on underlying batches rather than the prev…
konjac Feb 18, 2025
549d2dd
Add comments and fix format check failure.
konjac Feb 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/dataframe.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ use datafusion::dataframe::{DataFrame, DataFrameWriteOptions};
use datafusion::execution::SendableRecordBatchStream;
use datafusion::parquet::basic::{BrotliLevel, Compression, GzipLevel, ZstdLevel};
use datafusion::prelude::*;
use futures::StreamExt;
use pyo3::exceptions::PyValueError;
use pyo3::prelude::*;
use pyo3::pybacked::PyBackedStr;
Expand Down Expand Up @@ -90,8 +91,16 @@ impl PyDataFrame {
}

fn __repr__(&self, py: Python) -> PyDataFusionResult<String> {
let df = self.df.as_ref().clone().limit(0, Some(10))?;
let batches = wait_for_future(py, df.collect())?;
let df = self.df.as_ref().clone();

let stream = wait_for_future(py, df.execute_stream()).map_err(py_datafusion_err)?;

let batches: Vec<RecordBatch> = wait_for_future(
py,
stream.take(10).collect::<Vec<_>>())
.into_iter()
.collect::<Result<Vec<_>,_>>()?;

let batches_as_string = pretty::pretty_format_batches(&batches);
match batches_as_string {
Ok(batch) => Ok(format!("DataFrame()\n{batch}")),
Expand Down
Loading