- 
                Notifications
    
You must be signed in to change notification settings  - Fork 133
 
Enable Dataframe to be converted into views which can be used in register_table #1016
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
    
  
     Merged
                    Changes from all commits
      Commits
    
    
            Show all changes
          
          
            21 commits
          
        
        Select commit
          Hold shift + click to select a range
      
      9d589a2
              
                add test_view
              
              
                kosiew 648c185
              
                feat: add into_view method to register DataFrame as a view
              
              
                kosiew e55ac9f
              
                add pytableprovider
              
              
                kosiew ca42449
              
                feat: add as_table method to PyTableProvider and update into_view to …
              
              
                kosiew d0c3163
              
                refactor: simplify as_table method and update documentation for into_…
              
              
                kosiew 8578713
              
                test: improve test_register_filtered_dataframe by removing redundant …
              
              
                kosiew 9cdd0dc
              
                test: enhance test_register_filtered_dataframe with additional assert…
              
              
                kosiew c207b6c
              
                ruff formatted
              
              
                kosiew 20dbfe8
              
                cleanup: remove unused imports from test_view.py
              
              
                kosiew 4b4c641
              
                docs: add example for registering a DataFrame as a view in README.md
              
              
                kosiew 12c4fe3
              
                docs: update docstring for into_view method to clarify usage as ViewT…
              
              
                kosiew 15ead1f
              
                chore: add license header to test_view.py
              
              
                kosiew 48eb8db
              
                ruff correction
              
              
                kosiew f73eebb
              
                refactor: rename into_view method to _into_view
              
              
                kosiew 6bba2e2
              
                ruff lint
              
              
                kosiew 7b0cbf1
              
                refactor: simplify into_view method and update Rust binding convention
              
              
                kosiew f594b46
              
                docs: add views section to user guide with example on registering views
              
              
                kosiew 90a6a8b
              
                feat: add register_view method to SessionContext for DataFrame regist…
              
              
                kosiew c31395f
              
                Merge branch 'main' into view
              
              
                kosiew f0837de
              
                docs: update README and user guide to reflect register_view method fo…
              
              
                kosiew 9d8cdb5
              
                docs: remove some documentation from PyDataFrame
              
              
                kosiew File filter
Filter by extension
Conversations
          Failed to load comments.   
        
        
          
      Loading
        
  Jump to
        
          Jump to file
        
      
      
          Failed to load files.   
        
        
          
      Loading
        
  Diff view
Diff view
There are no files selected for viewing
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| .. Licensed to the Apache Software Foundation (ASF) under one | ||
| .. or more contributor license agreements. See the NOTICE file | ||
| .. distributed with this work for additional information | ||
| .. regarding copyright ownership. The ASF licenses this file | ||
| .. to you under the Apache License, Version 2.0 (the | ||
| .. "License"); you may not use this file except in compliance | ||
| .. with the License. You may obtain a copy of the License at | ||
| 
     | 
||
| .. http://www.apache.org/licenses/LICENSE-2.0 | ||
| 
     | 
||
| .. Unless required by applicable law or agreed to in writing, | ||
| .. software distributed under the License is distributed on an | ||
| .. "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| .. KIND, either express or implied. See the License for the | ||
| .. specific language governing permissions and limitations | ||
| .. under the License. | ||
| 
     | 
||
| ====================== | ||
| Registering Views | ||
| ====================== | ||
| 
     | 
||
| You can use the context's ``register_view`` method to register a DataFrame as a view | ||
| 
     | 
||
| .. code-block:: python | ||
| 
     | 
||
| from datafusion import SessionContext, col, literal | ||
| 
     | 
||
| # Create a DataFusion context | ||
| ctx = SessionContext() | ||
| 
     | 
||
| # Create sample data | ||
| data = {"a": [1, 2, 3, 4, 5], "b": [10, 20, 30, 40, 50]} | ||
| 
     | 
||
| # Create a DataFrame from the dictionary | ||
| df = ctx.from_pydict(data, "my_table") | ||
| 
     | 
||
| # Filter the DataFrame (for example, keep rows where a > 2) | ||
| df_filtered = df.filter(col("a") > literal(2)) | ||
| 
     | 
||
| # Register the dataframe as a view with the context | ||
| ctx.register_view("view1", df_filtered) | ||
| 
     | 
||
| # Now run a SQL query against the registered view | ||
| df_view = ctx.sql("SELECT * FROM view1") | ||
| 
     | 
||
| # Collect the results | ||
| results = df_view.collect() | ||
| 
     | 
||
| # Convert results to a list of dictionaries for display | ||
| result_dicts = [batch.to_pydict() for batch in results] | ||
| 
     | 
||
| print(result_dicts) | ||
| 
     | 
||
| This will output: | ||
| 
     | 
||
| .. code-block:: python | ||
| 
     | 
||
| [{'a': [3, 4, 5], 'b': [30, 40, 50]}] | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              | Original file line number | Diff line number | Diff line change | 
|---|---|---|
| @@ -0,0 +1,49 @@ | ||
| # Licensed to the Apache Software Foundation (ASF) under one | ||
| # or more contributor license agreements. See the NOTICE file | ||
| # distributed with this work for additional information | ||
| # regarding copyright ownership. The ASF licenses this file | ||
| # to you under the Apache License, Version 2.0 (the | ||
| # "License"); you may not use this file except in compliance | ||
| # with the License. You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, | ||
| # software distributed under the License is distributed on an | ||
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| 
     | 
||
| 
     | 
||
| from datafusion import SessionContext, col, literal | ||
| 
     | 
||
| 
     | 
||
| def test_register_filtered_dataframe(): | ||
| ctx = SessionContext() | ||
| 
     | 
||
| data = {"a": [1, 2, 3, 4, 5], "b": [10, 20, 30, 40, 50]} | ||
| 
     | 
||
| df = ctx.from_pydict(data, "my_table") | ||
| 
     | 
||
| df_filtered = df.filter(col("a") > literal(2)) | ||
| 
     | 
||
| ctx.register_view("view1", df_filtered) | ||
| 
     | 
||
| df_view = ctx.sql("SELECT * FROM view1") | ||
| 
     | 
||
| filtered_results = df_view.collect() | ||
| 
     | 
||
| result_dicts = [batch.to_pydict() for batch in filtered_results] | ||
| 
     | 
||
| expected_results = [{"a": [3, 4, 5], "b": [30, 40, 50]}] | ||
| 
     | 
||
| assert result_dicts == expected_results | ||
| 
     | 
||
| df_results = df.collect() | ||
| 
     | 
||
| df_result_dicts = [batch.to_pydict() for batch in df_results] | ||
| 
     | 
||
| expected_df_results = [{"a": [1, 2, 3, 4, 5], "b": [10, 20, 30, 40, 50]}] | ||
| 
     | 
||
| assert df_result_dicts == expected_df_results | 
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
              
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general I think this is a good idea, but I'm worried about causing confusion with a table provider created from a view and a table provider that is passed from an external source using pycapsule. I can imagine a user would think that a table provider object from one place can be used with another. That is, if I create a table provider with into_view I should be able to register it with the session context. Now, I don't think that operation is strictly necssary but I do expect it would cause some confusion.
What I think we want to do is to have a single common PyTableProvider that can be created either via a pycapsule or into_view.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean a constructor that takes a pycapsule argument, then extract provider to use in
PyTableProvider::new(provider)?
Can I check how I can obtain the provider from
pub struct PyCapsule(PyAny)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@timsaucer
Any chance you can give me some code points or reference PRs that would help with implementation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What if we just skip the whole creating a view as a table provider and instead go straight to registering a view on the session context?
We could do something like
register_view(df: DataFrame)which would under the hood do exactly what you've got except not expose it back as aPyTableProviderand eliminate any possible confusion. Then we'd also save the user a step.@matko would that solve your needs or do you need that view table provider exposed for other use?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise I think we have to plan for how we can have a common concept around two ways of creating table providers in python code. Also we would want to think about how we would handle the return type of a udtf, which we haven't even addressed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds good.
Implemented.