feat/improve ruff test coverage #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CrystalZhou0529 would you mind reviewing the changes I made to |
… in to all methods
timsaucer
force-pushed
the
feat/greater-ruff-coverage
branch
from
5bbb822 to
5f3f7c7
Compare
…ent minimal supported version
…ther changes will come in apache#1043 that is soon to be merged.
|
#1056 contains the follow on work to apply additional rules |
Closed
crystalxyz
reviewed
Mar 11, 2025
Comment on lines
+114
to
+131
| @overload | ||
| @staticmethod | ||
| def udf( | ||
| input_types: list[pa.DataType], | ||
| return_type: _R, | ||
| volatility: Volatility | str, | ||
| name: Optional[str] = None, | ||
| ) -> Callable[..., ScalarUDF]: ... | ||
|
|
||
| @overload | ||
| @staticmethod | ||
| def udf( | ||
| func: Callable[..., _R], | ||
| input_types: list[pa.DataType], | ||
| return_type: _R, | ||
| volatility: Volatility | str, | ||
| name: Optional[str] = None, | ||
| ) -> ScalarUDF: ... |
There was a problem hiding this comment.
Thanks for sharing this with me! I wasn't aware of this way to overload a function in Python but this is so much cleaner than the previous version. I really appreciate your effort here.
kevinjqliu
approved these changes
Mar 12, 2025
| readme = "README.md" | ||
| license = { file = "LICENSE.txt" } | ||
| requires-python = ">=3.8" | ||
| requires-python = ">=3.9" |
There was a problem hiding this comment.
should we split out this python version bump?
There was a problem hiding this comment.
I don't know why the diff doesn't show, but that's already merged into main
|
|
||
| [[package]] | ||
| name = "datafusion" | ||
| version = "44.0.0" |
There was a problem hiding this comment.
i cant find any reasons why this was removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
During a recent push #1052 , we discovered the need to enable additional ruff checks to catch errors in the repo before they get merged into main. This PR enables many more ruff checks and creates a list of those we still should address or choose to ignore.
What changes are included in this PR?
ALMOST all of the changes are slight formatting. There are some changes to
udafandudfdecorator/functions.Are there any user-facing changes?
These should be transparent to the user.