Skip to content

Conversation

@timsaucer
Copy link
Member

Which issue does this PR close?

None

Rationale for this change

DataFusion 47 is updating upstream.

What changes are included in this PR?

Mostly small changes such as adding explicit types and accounting for API upstream changes.

Are there any user-facing changes?

None

Copy link
Member

@davisp davisp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything amiss, but I'm not familiar enough to give a full approval.

Copy link

@robtandy robtandy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks right to me.

}

aggregate_function_vec_args!(last_value);
// We handle first_value explicitly because the signature expects an order_by

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this comment address first and last value?

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @timsaucer

@timsaucer timsaucer marked this pull request as ready for review April 24, 2025 13:38
@timsaucer timsaucer merged commit d0d14f6 into apache:main Apr 24, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants