Skip to content

Fix Python UDAF Accumulator Interface example to Properly Handle State and Updates with List[Array] Types #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 28, 2025
Merged

Fix Python UDAF Accumulator Interface example to Properly Handle State and Updates with List[Array] Types #1192

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba0b49e
Merge branch 'main' into dev
kosiew Jun 13, 2025
6dcb82c
Add test for user-defined aggregation function (UDAF) with DataFusion
kosiew Jul 25, 2025
3ae3260
fix: update UDAF implementation to use correct pyarrow compute functions
kosiew Jul 25, 2025
8541b25
fix: correct comment capitalization and remove unused import in UDAF …
kosiew Jul 25, 2025
94479d3
Merge branch 'main' into udaf-1190
kosiew Jul 27, 2025
5ef214e
fix: update UDAF accumulator methods to handle state and summation co…
kosiew Jul 27, 2025
6318511
Remove test script
kosiew Jul 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions examples/sql-using-python-udaf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,16 +28,16 @@ class MyAccumulator(Accumulator):
def __init__(self) -> None:
self._sum = pa.scalar(0.0)

def update(self, values: pa.Array) -> None:
def update(self, values: list[pa.Array]) -> None:
# not nice since pyarrow scalars can't be summed yet. This breaks on `None`
self._sum = pa.scalar(self._sum.as_py() + pa.compute.sum(values).as_py())

def merge(self, states: pa.Array) -> None:
# not nice since pyarrow scalars can't be summed yet. This breaks on `None`
self._sum = pa.scalar(self._sum.as_py() + pa.compute.sum(states).as_py())
self._sum = pa.scalar(self._sum.as_py() + pa.compute.sum(states[0]).as_py())

def state(self) -> pa.Array:
return pa.array([self._sum.as_py()])
def state(self) -> list[pa.Array]:
return [self._sum]

def evaluate(self) -> pa.Scalar:
return self._sum
Expand Down
Loading