Improve show()
output for empty DataFrames
#1208
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
When calling
show()
on a DataFrame with no rows, the current output may be misleading or unclear. This PR enhances the user experience by providing a clear message indicating that the DataFrame has no rows. This makes debugging and usage more intuitive, especially in cases where filters or queries return empty results.What changes are included in this PR?
Added a conditional check in
print_dataframe
to handle the case whereDataFrame.collect()
returns no batches.If the DataFrame has no rows, output "DataFrame has no rows".
Added tests for various scenarios:
SELECT
query that returns no rows.Are these changes tested?
Yes, comprehensive tests have been added using
capsys
to verify theshow()
output under multiple empty DataFrame scenarios:test_show_empty
test_show_select_where_no_rows
test_show_from_empty_batch
Are there any user-facing changes?
Yes:
show()
is called on an empty DataFrame, the output is now:DataFrame has no rows