-
Notifications
You must be signed in to change notification settings - Fork 131
Support string column identifiers for sort/aggregate/window and stricter Expr validation #1221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
f9cafb8
refactor: improve DataFrame expression handling, type checking, and docs
kosiew 91167b0
refactor: unify expression and sorting logic; improve docs and error …
kosiew 54687a2
feat: add ensure_expr helper for validation; refine expression handli…
kosiew f591617
Refactor and enhance expression handling, test coverage, and document…
kosiew 31a648f
refactor: update docstring for sort_or_default function to clarify it…
kosiew 37307b0
fix Ruff errors
kosiew 05cd237
refactor: update type hints to use typing.Union for better clarity an…
kosiew 28619d9
fix Ruff errors
kosiew 9adbf4f
refactor: simplify type hints by removing unnecessary imports for typ…
kosiew 0a27617
refactor: update type hints for rex_type and types methods to improve…
kosiew 92bc68e
refactor: remove unnecessary type ignore comments from rex_type and t…
kosiew 7258428
docs: update section title for clarity on DataFrame method arguments
kosiew c3e2a04
docs: clarify description of DataFrame methods accepting column names
kosiew 38043fa
docs: add note to clarify function documentation reference for DataFr…
kosiew d78fdef
docs: remove outdated information about predicate acceptance in DataF…
kosiew 992d619
refactor: simplify type hint for expr_list parameter in expr_list_to_…
kosiew bd0f57e
docs: clarify usage of datafusion.col and datafusion.lit in DataFrame…
kosiew 2b813bf
docs: clarify usage of col() and lit() in DataFrame filter examples
kosiew 93c81fa
Merge branch 'main' into col-1214
kosiew 9aa9985
Fix ruff errors
kosiew File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.