feat: expose DataFrame.parse_sql_expr
#1274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Tim Saucer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
It is related to #1273 but may not close it fully
Closes #.
Rationale for this change
I have quite a lot use cases where expressions are coming as strings, this method would help covering those cases
What changes are included in this PR?
This change exposes
DataFrame.parse_sql_exras a helper method to parse strings to datafusion expressions.I'm split on this PR, I believe we should have dual
Exp | strparameters whenever makes sense, but that work would take some time, until we get there this would be useful utility toolAre there any user-facing changes?