Skip to content

Bugfix: Calling count with None arguments #768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 1, 2024
Merged

Bugfix: Calling count with None arguments #768

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cabf83
Small bugfix. When arguments are None, we should use count_star
timsaucer Jul 24, 2024
1a068e0
When no arguments are given to count, set argument to lit(1) so that …
timsaucer Jul 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions python/datafusion/functions.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1294,6 +1294,8 @@ def corr(value1: Expr, value2: Expr, distinct: bool = False) -> Expr:

def count(args: Expr | list[Expr] | None = None, distinct: bool = False) -> Expr:
"""Returns the number of rows that match the given arguments."""
if args is None:
return Expr(f.count_star())
if isinstance(args, list):
args = [arg.expr for arg in args]
elif isinstance(args, Expr):
Expand Down
Loading