Add typing-extensions dependency to pyproject #805
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylebarron
reviewed
Aug 13, 2024
Co-authored-by: Kyle Barron <[email protected]>
Michael-J-Ward
approved these changes
Aug 13, 2024
andygrove
pushed a commit
that referenced
this pull request
Aug 16, 2024
* Add typing-extensions dependency to pyproject * Specify versions which require typing extensions. Co-authored-by: Kyle Barron <[email protected]> --------- Co-authored-by: Kyle Barron <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is related to #804
Rationale for this change
#750 introduced wrapper classes that include the
@deprecatedannotation on a few functions. Iftyping-extensionsis not installed,import datafusionwill fail.What changes are included in this PR?
Adds typing extensions to the pyproject so that pip will ensure it is installed.
Are there any user-facing changes?
None