fix: Calling count on a pyarrow dataset results in an error
#843
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Michael-J-Ward
force-pushed
the
bug-arrow-count
branch
from
ae7470e to
ef8d253
Compare
Michael-J-Ward
force-pushed
the
bug-arrow-count
branch
from
ef8d253 to
f6f353c
Compare
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #800.
Rationale for this change
This PR includes a test to demonstrate the issue, which was resolved with an upstream PR: apache/arrow-rs#6318.
I have now rebased the PR against latest on main, which includes that upstream PR and thus the tests pass.
What changes are included in this PR?
Are there any user-facing changes?
df.count()succeeds on arrow datasets.